Cherry-pick stability fix from astcenc 4.1.0 release #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @solidpixel. |
AnonN10
added a commit
to AnonN10/KTX-Software
that referenced
this pull request
Aug 19, 2022
Cherry-pick change from astcenc 4.1.0 (KhronosGroup#623)
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
Without the fix SSE2 and SSE4.1 builds that use the decompressor APIs can generate faults on masked stores, as _mm_maskmoveu_si128() doesn't suppress faults on any lanes that are disabled. AVX2 builds are not impacted by this - the AVX2 masked store does suppress faults on masked lanes.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Without the fix SSE2 and SSE4.1 builds that use the decompressor APIs can generate faults on masked stores, as _mm_maskmoveu_si128() doesn't suppress faults on any lanes that are disabled. AVX2 builds are not impacted by this - the AVX2 masked store does suppress faults on masked lanes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of a fix for the astcenc compressor backend that we made in the astcenc 4.1.0 release.
Without the fix SSE2 and SSE4.1 builds that use the decompressor APIs can generate faults on masked stores, as
_mm_maskmoveu_si128()doesn't suppress faults on any lanes that are disabled. AVX2 builds are not impacted by this - the AVX2 masked store does suppress faults on masked lanes.