Fix newly emerged warning from clang #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a warning from a recent code change in toktx.cc.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
and a warning from a recent code change in toktx.cc. The new clang warning has appeared, without a bump in the LLVM version number, because Emscripten releases pull the top of tree LLVM and our CI gets the latest Emscripten release. LLVM is in the final throes of developing their 15.0.0 release. As there is no version number change we've had to use the `__has_warning` pre-processor directive and thus modify the offending BasisU file. Note that MS VC++ also has `__has_warning` but with a different syntax so this fix uses the directive only when `__clang__` is defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
and a warning from a recent code change in toktx.cc. The new clang warning has appeared, without a bump in the LLVM version number, because Emscripten releases pull the top of tree LLVM and our CI gets the latest Emscripten release. LLVM is in the final throes of developing their 15.0.0 release. As there is no version number change we've had to use the `__has_warning` pre-processor directive and thus modify the offending BasisU file. Note that MS VC++ also has `__has_warning` but with a different syntax so this fix uses the directive only when `__clang__` is defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
and a warning from a recent code change in toktx.cc. The new clang warning has appeared, without a bump in the LLVM version number, because Emscripten releases pull the top of tree LLVM and our CI gets the latest Emscripten release. LLVM is in the final throes of developing their 15.0.0 release. As there is no version number change we've had to use the `__has_warning` pre-processor directive and thus modify the offending BasisU file. Note that MS VC++ also has `__has_warning` but with a different syntax so this fix uses the directive only when `__clang__` is defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
and a warning from a recent code change in toktx.cc. The new clang warning has appeared, without a bump in the LLVM version number, because Emscripten releases pull the top of tree LLVM and our CI gets the latest Emscripten release. LLVM is in the final throes of developing their 15.0.0 release. As there is no version number change we've had to use the `__has_warning` pre-processor directive and thus modify the offending BasisU file. Note that MS VC++ also has `__has_warning` but with a different syntax so this fix uses the directive only when `__clang__` is defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
and a warning from a recent code change in toktx.cc. The new clang warning has appeared, without a bump in the LLVM version number, because Emscripten releases pull the top of tree LLVM and our CI gets the latest Emscripten release. LLVM is in the final throes of developing their 15.0.0 release. As there is no version number change we've had to use the `__has_warning` pre-processor directive and thus modify the offending BasisU file. Note that MS VC++ also has `__has_warning` but with a different syntax so this fix uses the directive only when `__clang__` is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a warning from a recent code change in toktx.cc.