Fix handling of combined depth-stencil textures #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
changed the title
in KhronosGroup/KTX-Specification#180. Fix DFD texel block sizes for D16_UNORM_S8_UINT and D32_SFLOAT_S8_UINT.
Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts defined there are never seen outside Vulkan. Create dfds for the KTX-defined within KTX library and tools. Fix createDFDDEpthStencil to give set primaries to UNSPECIFIED.
MarkCallow
force-pushed
the
fix_alignment_calc
branch
from
c5ebb34 to
15cb2a8
Compare
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
Fix required alignment calculations in accordance with the spec. change in KhronosGroup/KTX-Specification#180. Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts defined there are never seen outside Vulkan. Create their dfds, with the texel block sizes specified by KTX, within the KTX library and tools. Fix createDFDDepthStencil to set the primaries to UNSPECIFIED for depth, stencil and depth-stencil formats. Make vk2dfd.inl visible in project.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fix required alignment calculations in accordance with the spec. change in KhronosGroup/KTX-Specification#180. Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts defined there are never seen outside Vulkan. Create their dfds, with the texel block sizes specified by KTX, within the KTX library and tools. Fix createDFDDepthStencil to set the primaries to UNSPECIFIED for depth, stencil and depth-stencil formats. Make vk2dfd.inl visible in project.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fix required alignment calculations in accordance with the spec. change in KhronosGroup/KTX-Specification#180. Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts defined there are never seen outside Vulkan. Create their dfds, with the texel block sizes specified by KTX, within the KTX library and tools. Fix createDFDDepthStencil to set the primaries to UNSPECIFIED for depth, stencil and depth-stencil formats. Make vk2dfd.inl visible in project.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fix required alignment calculations in accordance with the spec. change in KhronosGroup/KTX-Specification#180. Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts defined there are never seen outside Vulkan. Create their dfds, with the texel block sizes specified by KTX, within the KTX library and tools. Fix createDFDDepthStencil to set the primaries to UNSPECIFIED for depth, stencil and depth-stencil formats. Make vk2dfd.inl visible in project.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Fix required alignment calculations in accordance with the spec. change in KhronosGroup/KTX-Specification#180. Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts defined there are never seen outside Vulkan. Create their dfds, with the texel block sizes specified by KTX, within the KTX library and tools. Fix createDFDDepthStencil to set the primaries to UNSPECIFIED for depth, stencil and depth-stencil formats. Make vk2dfd.inl visible in project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix required alignment calculations in accordance with the spec. change in
KhronosGroup/KTX-Specification#180.
Remove creation of DFDs for these from dfdutils' vk2dfd as the layouts
defined there are never seen outside Vulkan. Create their dfds, with the
texel block sizes specified by KTX, within the KTX library and tools.
Fix createDFDDepthStencil to set the primaries to UNSPECIFIED for depth, stencil
and depth-stencil formats.
Make vk2dfd.inl visible in project.