405 cmake issue when building conda on fedora #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-orange
force-pushed
the
405-cmake-issue-when-building-conda-on-fedora
branch
2 times, most recently
from
07631ba to
01b2c64
Compare
bruno-at-orange
force-pushed
the
405-cmake-issue-when-building-conda-on-fedora
branch
2 times, most recently
from
4bdfa22 to
201819a
Compare
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
popescu-v
reviewed
Oct 22, 2024
popescu-v
requested changes
Oct 22, 2024
bruno-at-orange
force-pushed
the
405-cmake-issue-when-building-conda-on-fedora
branch
2 times, most recently
from
0b74ab4 to
03a5ab4
Compare
popescu-v
reviewed
Oct 28, 2024
We let CMake choose the good compiler with the variables provided by the compiler packages. By setting 'gcc' in the preset, the Conda build used the system-wide GCC
When we configure the project on fedora. A fatal error is triggered if the variable MPI_BIN is not defined. On conda, this variable is not required.
The conda version doesn't contain dashes. We handle this directly in the conda.yml with a search and replace. Rather than doing it upstream, befor calling conda build. It simplifies both local and CI builds.
From cmake version 3.4 WINDOWS_EXPORT_ALL_SYMBOLS is needed to produce lib file alongside the dll
popescu-v
force-pushed
the
405-cmake-issue-when-building-conda-on-fedora
branch
5 times, most recently
from
c711634 to
386cc81
Compare
|
Implemented the remaining agreed-upon modification suggestion in the comments: renaming of |
popescu-v
approved these changes
Oct 31, 2024
popescu-v
force-pushed
the
405-cmake-issue-when-building-conda-on-fedora
branch
from
386cc81 to
bff958f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes and improvements that I have made to package khiops on conda-forge.
There is a major fix concerning the use of the compiler of conda instead of the system wide one (commit 2b317f4)
close #403
close #405