191 test khiopspydev docker images before pushing them to the registry #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popescu-v
force-pushed
the
191-test-khiopspydev-docker-images-before-pushing-them-to-the-registry
branch
2 times, most recently
from
f1018d5 to
d82e70e
Compare
|
If I understood well, the docker image for dev will be still named (and tagged) this way : It seems that the image revision is set manuallly by the user. There may be a risk that 2 users set the same image revision and thus overwrite the image. But it may be an acceptable risk. |
Yes, IMHO it is an acceptable risk. Otherwise, we would need a different mechanism for ensuring no override occurs, e.g. use the commit hash in / as the image revision part of the Docker image tag (less readable)? |
folmos-at-orange
requested changes
Aug 22, 2024
popescu-v
force-pushed
the
191-test-khiopspydev-docker-images-before-pushing-them-to-the-registry
branch
2 times, most recently
from
64ea4c6 to
0aeb5ce
Compare
- don't push image to GH registry by default - use versioning for the Docker image - drop the `test` job for the Docker images: Khiops packages are tested upstream - add 'latest' Docker tag to image if on `dev` or `main` branches
To this end, add separate development Docker image tag output. Indeed, `env` is not accessible in the `image` context, because it's not in a step (see https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/contexts#env-context).
The `maison` dependency just had a new 2.0 release with breaking changes (https://github.com/dbatten5/maison/releases/tag/v2.0.0) which break yamlfix (see lyz-code/yamlfix#286).
popescu-v
force-pushed
the
191-test-khiopspydev-docker-images-before-pushing-them-to-the-registry
branch
from
0aeb5ce to
184b9d3
Compare
folmos-at-orange
approved these changes
Aug 22, 2024
Indeed, `.feature_evaluated_importances` is a 1-D array with one scalar (the level) per feature. Note: this is launched as a test only when "long" unit tests are enabled.
folmos-at-orange
approved these changes
Aug 23, 2024
popescu-v
deleted the
191-test-khiopspydev-docker-images-before-pushing-them-to-the-registry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #191