-
Notifications
You must be signed in to change notification settings - Fork 75
Read prettier config file if exists to determine prettier options #172
Conversation
CLA signature looks good 👍 |
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
===========================================
+ Coverage 0 98.60% +98.60%
===========================================
Files 0 5 +5
Lines 0 358 +358
Branches 0 57 +57
===========================================
+ Hits 0 353 +353
- Misses 0 5 +5
|
cli.js now creates a new commander.Command instance for every run instead of using the default instance. This was necessary because options are cached which made some unit tests fail by options being carried over from previous tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this feature and for the awesome tests. This change appears to break permalinks in the playground. It just loads the page with all of the defaults. That'll need to be fixed before this can be merged.
Merge new commits from base repo
Found the problem. Should work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice! It will decrease the git diff, and so it will be easier to review the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing the permalink issue.
closes #78