Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Read prettier config file if exists to determine prettier options #172

Merged
merged 6 commits into from
Dec 19, 2020

Conversation

spiroka
Copy link
Contributor

@spiroka spiroka commented May 9, 2020

closes #78

@khanbot
Copy link

khanbot commented May 9, 2020

CLA signature looks good 👍

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #172 (bc629ec) into master (aae6783) will increase coverage by 98.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #172       +/-   ##
===========================================
+ Coverage        0   98.60%   +98.60%     
===========================================
  Files           0        5        +5     
  Lines           0      358      +358     
  Branches        0       57       +57     
===========================================
+ Hits            0      353      +353     
- Misses          0        5        +5     
Impacted Files Coverage Δ
src/convert.js 92.30% <ø> (ø)
src/cli.js 100.00% <100.00%> (ø)
src/compute-newlines.js 97.72% <0.00%> (ø)
src/transform.js 99.15% <0.00%> (ø)
src/detect-jsx.js 100.00% <0.00%> (ø)

@spiroka
Copy link
Contributor Author

spiroka commented May 9, 2020

cli.js now creates a new commander.Command instance for every run instead of using the default instance. This was necessary because options are cached which made some unit tests fail by options being carried over from previous tests.

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature and for the awesome tests. This change appears to break permalinks in the playground. It just loads the page with all of the defaults. That'll need to be fixed before this can be merged.

@spiroka
Copy link
Contributor Author

spiroka commented Oct 6, 2020

Found the problem. Should work now.

Copy link
Contributor

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice! It will decrease the git diff, and so it will be easier to review the changes!

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the permalink issue.

@kevinbarabash kevinbarabash merged commit f09c2e6 into Khan:master Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read .prettierrc if exists to determine prettier options
4 participants