Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mob factions #509

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix mob factions #509

merged 1 commit into from
Dec 2, 2024

Conversation

snipercup
Copy link
Collaborator

I caused elshad's work to stop working when I solved conflicts. This pr fixes the problem.

The faction editor can read the json file, but there is still an issue when saving. Elshad plans to work more on it anyway so I didn't fix that issue.

@snipercup snipercup added the bug Something isn't working label Dec 2, 2024
@snipercup snipercup merged commit 5370aba into Khaligufzel:main Dec 2, 2024
@snipercup snipercup deleted the factionsfix branch December 2, 2024 18:14
@Elshad19
Copy link
Collaborator

Elshad19 commented Dec 2, 2024

Thank you, I'd love to fix it, but unfortunately I think it is beyond my skill level. I currently play around the code and mostly copy/paste.

Of course I don't want to load you with more work as well, but as of now I have no idea how I am going to fix it.

Any guide would be very appreciated if you want me to deal with it.

@snipercup
Copy link
Collaborator Author

You have good communication skills. Thanks for letting me know what your limits are. That's perfectly fine. I'm thinking I will identify some issues with your commits and post new issues here on github with some hits on how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants