-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add furniture to game #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the materials are generated, set the proper uv scaling so they are correctly visualized in-game.
This fixes the situation where if two map editors are opened, only the last one receives input from the scroll wheel
Improved saving loading, added duplicate and delete buttons, icons
Add name and description labels to show info on a tile
Overmap chunks will stay consistent even after changing scenes.
Tile overmap coordinates are now consistent Added a home button to return to 0,0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #34 to work. I will publish this PR as a draft to make sure #34 gets merged first.
This pr adds furniture to the game
There are some problems with the furniture:
I experimented with the physics for a bit. We can change the sphere collision shape to a box and then lock the x and y rotation so it can only rotate on the y axis. The problem with this is that it introduces weird behaviour where you can push furniture in one direction but not the other even though there is nothing blocking it. Pushing up slopes is very difficult with only a little weight applied. The benefit is that we can introduce weight and friction and it won't clip into the wall as much as the current implementation. My guess is that if we want this there will be some custom code and it will take time to get rid of all the bugs
An alternative is that we switch to Jolt physics, something that has been advised when I looked up help on the rigidbody3d. It shouldn't be too hard to implement and it works with Godot 4.2. Jolt physics is not entirely bug free either but it has been recommended as an alternative to Godot native physics.