Support Python 3.12 and drop Python 3.8 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spent four hours trying to fix this and not a single step closer. I'm getting really annoyed with poetry. |
benvanwerkhoven
changed the title
|
It seems we can only support Python 3.12 by dropping support for Python 3.8, because the requirements export functionality in Poetry can't work with disjunctive sets of dependencies for different Python versions. As such, this pull request is now also about dropping Python 3.8, which might require more changes to the code. |
As described in actions/runner-images#9770, `macos-latest` was missing cached Python versions 3.9 and 3.10, forcing temporary use of `macos-13`. As the Python versions have been added, we can again use `macos-latest`.
|
|
@benvanwerkhoven this PR is now ready to be merged. |
|
Tested locally and on the DAS, it works! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pyproject.toml locked our Python version to less then 3.12. This pull should add support for Python 3.12 and also enables the CI to test against 3.12.