New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch RuntimeError when importing from pyhip #252

Merged

benvanwerkhoven merged 1 commit into KernelTuner:master from loostrum:fix_hip_import

Apr 16, 2024

Member

loostrum commented Apr 16, 2024

If pyhip is installed but ROCm is not available/loaded (e.g. on the DAS-6 headnode), importing pyhip fails with a RuntimeError instead of ImportError. This makes KernelTuner crash completely instead of just HIP being unavailable. I've changed the hip backend and observer to catch the RuntimeError as well to fix this.


          Catch RuntimeError when importing from pyhip

ce5609f

sonarqubecloud bot commented Apr 16, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Collaborator

benvanwerkhoven commented Apr 16, 2024

Thanks @loostrum!

benvanwerkhoven merged commit 57e43b2 into KernelTuner:master

3 checks passed

loostrum deleted the fix_hip_import branch

April 17, 2024 11:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet