Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "Contact Groups with manual macro" module to V4 report #208

Closed
6 tasks
ChristopherJennings opened this issue Apr 25, 2019 · 0 comments · Fixed by #375
Closed
6 tasks

Migrate "Contact Groups with manual macro" module to V4 report #208

ChristopherJennings opened this issue Apr 25, 2019 · 0 comments · Fixed by #375

Comments

@ChristopherJennings
Copy link
Contributor

Overview

We should migrate the Contact groups with manual macro module to the new V4 report format.

Definition of done

  • Code and Scripts are ported to KenticoInspector.Reports project in a dedicated folder for the report.
  • Scripts are referenced via constants in a static class.
  • Scripts are refactored to return simple results that are mappable to simple classes.
  • Report logic is covered by unit test for a clean result
  • Report logic is covered by unit tests for all known dirty results
  • Useful, non-specific logic is abstracted to services or helpers.

Note: The Class/Table Validation report (and it's tests) is a good, simple example of the main concepts.

Additional Details (optional)

  • New name: Contact Group Analysis
  • Tags: Performance, Online Marketing
kentico-ericd added a commit that referenced this issue Aug 3, 2023
@kentico-ericd kentico-ericd linked a pull request Aug 8, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant