Lusfixes1 #7
Merged
Lusfixes1 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenix3
force-pushed
the
lusfixes1
branch
7 times, most recently
from
f8c2c8a to
1166075
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
briaguya-ai
reviewed
Nov 7, 2022
There was a problem hiding this comment.
overall there are a ton of improvements, but i took this as a chance to go through and see if there are any naming conventions with room for improvement
found a few things, left some suggestions and questions, i'm very much in "strong opinions loosely held" mode on these so i'm very open to disagreement
Kenix3
force-pushed
the
lusfixes1
branch
2 times, most recently
from
56914bf to
3e4835c
Compare
Kenix3
added a commit
that referenced
this pull request
Jan 3, 2023
* Organizes libultraship files into directories. * Adds StormLib, ZAPDUTILS, and tidies up /lib/ * Moves include up a directory and moves abi.h to include. * Fixes gitignore to only ignore build folders, and commits forgotten files. * update CMakeLists and `#include`s to match directory structure * Windows CMake now builds project files. * Restructure CMake project * feat: sdl via vcpkg (#1) Co-authored-by: briaguya <briaguya@alice> * Build via VS generator * Use ccache for faster building * Error CI workflow on no lib generated * Remove unused lib (mINI) * Update embedded lib (nlohmann-json) * Cleanup main CMakeLists.txt * Remove unecessary header * Use Ninja for MSVC * Update embedded lib (spdlog) * Update embedded lib (StormLib) * Improve CMake structure * define NOMINMAX for certain windows files * Add and run clang-format * Add and run clang-tidy * Add CI workflow for clang-format/tidy * Split CI workflows * Use new format validation * Fixes typos preventing patch OTRs from working on Switch (#8) * Removes third party BinaryTools and re-implements and reloacates ZAPDUtils Binary Tools. (#7) * Removes third party BinaryTools and implements ZAPDUtils' into LUS. * Attempts to make the Linter happy. * Another run of linter fixing improvements. * Should be last linting-related change. * Fixes tidy-format-validation to only check src and include directories in the git diff Co-authored-by: briaguya <briaguya@alice> Co-authored-by: David Chavez <[email protected]> Co-authored-by: briaguya <[email protected]> Co-authored-by: Christopher Leggett <[email protected]>
Archez
added a commit
to Archez/libultraship
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit 21a5df5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.