Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.1.5 is broken due to incorrect auto-value configuration #147

Closed
remal opened this issue Feb 1, 2022 · 4 comments · Fixed by #150
Closed

Version 0.1.5 is broken due to incorrect auto-value configuration #147

remal opened this issue Feb 1, 2022 · 4 comments · Fixed by #150
Labels

Comments

@remal
Copy link

remal commented Feb 1, 2022

I'm trying to set up errorprone-slf4j v0.1.5 and ErrorProne doesn't discover its checks.

As I can see in the commit c4b9ea2 this was added to pom.xml:

errorprone-slf4j/pom.xml

Lines 76 to 82 in c4b9ea2

<annotationProcessorPaths>
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>${version.errorprone}</version>
</path>
</annotationProcessorPaths>

By adding this, com.google.auto.service:auto-service annotation processor became disabled.

As you can see, in the created JAR file, there is no META-INF/services/ file. That's why ErrorProne can find checks of errorprone-slf4j.

The issue can be fixed, by adding this dependency into annotationProcessorPaths:

errorprone-slf4j/pom.xml

Lines 111 to 113 in c4b9ea2

<groupId>com.google.auto.service</groupId>
<artifactId>auto-service</artifactId>
<version>1.0.1</version>

@KengoTODA
Copy link
Owner

Confirmed that the latest master branch 2d8197e does not have this problem:

   creating: META-INF/services/
  inflating: META-INF/services/com.google.errorprone.bugpatterns.BugChecker  

It is because I've replaced the build tool from Maven to Gradle, and in its procedure I've fixed it unintentionally. I will ship 0.1.6 later. Thanks for your notice!

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

🎉 This issue has been resolved in version 0.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

🎉 This issue has been resolved in version 0.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KengoTODA
Copy link
Owner

v0.1.6 is now ready on Maven Central. Thanks again for your report @remal!
https://repo1.maven.org/maven2/jp/skypencil/errorprone/slf4j/errorprone-slf4j/0.1.6/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants