add domain validation #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current domain validation does miss some valid domains since it follows the HTML spec which doesn't cover 100% of valid emails. I don't think I want to add more though, or maybe just fix the existing regex to fit more cases. |
|
It would be useful to also add derive support to quoting.rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validator crate has a private method
validate_domain_part()in email.rs, this method maybe enough for email validation, but as far as i know, it not suitable for all domain names, like FQDN and SRV type domain name, such as_jabber._tcp.gmail.com, so i think it may be useful to write a independent method for domain validate only.There are some RFC for domain name definition and modification, such as RFC 1034,RFC 1035 and RFC 2181.