Patch ethermint gas tracking #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
galxy25
force-pushed
the
patch-ethermint-gas-tracking
branch
2 times, most recently
from
19685b6 to
3632253
Compare
galxy25
force-pushed
the
patch-ethermint-gas-tracking
branch
from
3632253 to
8cc5bdd
Compare
DracoLi
reviewed
Nov 29, 2023
| @@ -432,6 +451,8 @@ func (k Keeper) TraceTx(c context.Context, req *types.QueryTraceTxRequest) (*typ | |||
| } | |||
| txConfig.TxHash = ethTx.Hash() | |||
| txConfig.TxIndex = uint(i) | |||
| // reset gas meter for each transaction | |||
| ctx = ctx.WithGasMeter(ethermint.NewInfiniteGasMeterWithLimit(uint64(0))) | |||
There was a problem hiding this comment.
is this for debugging? Seem like this should be reset to msg.Gas() for the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now these changes are based off the v0.24.1 release branch (so that I can build and test it on the current mainnet boxes that are running an older version of rocksdb), assuming the changeset is approved I'll rebase this pr to be off of the planned v0.25 release and master branches
Description
Issue 1
Issue 2
Issue 3