Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/SoleNestedConditional cop #11066

Merged

Conversation

archanaserver
Copy link
Contributor

What are the changes introduced in this pull request?

#11009
This pull request addresses the Style/SoleNestedConditional RuboCop offense by refactoring conditional logic in the codebase.

https://docs.rubocop.org/rubocop/cops_style.html#stylesolenestedconditional

Considerations taken when implementing this change?

Refactored nested conditionals.

What are the testing steps for this pull request?

bundle exec rubocop

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some indentation issues.

@archanaserver archanaserver force-pushed the fix-style/solenestedconditional branch from a32b436 to 3a98c7a Compare July 11, 2024 07:20
@archanaserver
Copy link
Contributor Author

Looks like there are some indentation issues.

Fixed it!

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me. I'm just going to re-run the one failing test because it was halted.

@archanaserver
Copy link
Contributor Author

Looking great to me. I'm just going to re-run the one failing test because it was halted.

@ianballou is this require any other changes?

@ianballou ianballou merged commit 0e430ab into Katello:master Jul 16, 2024
27 of 28 checks passed
@ianballou
Copy link
Member

@archanaserver thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants