Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanish language locale #887

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

CarlosVMX1
Copy link

Description

Added es.json file to the locale folder to use spanish language.

Motivation and Context

There was not spanish file so I added it.

How Has This Been Tested?

I had been using it for some days, all works correct.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@PokeMapGo
Copy link

Just a quick note:

-Keep the initial capital letter i.e: "All team's": "todos los equipos"
-Use the original game translation i.e:
"Make 5 Great Curveball Throws in a row": "Haz 5 lanzamientos Geniales en curva seguidos" ---> Haz 5 grandes lanzamientos de bola curva seguidos
-This is not the same: "404 No valid invasion types found": "Error de comando",

Anyway, great job, I always forget to PR this locale

@CarlosVMX1
Copy link
Author

Hey @PokeMapGo if you have a better spanish locale I’m happy to remove this one, added it only because almost all my friends plays on spanish and I was not able to find that translation so I shared mine, but I see that the text translated from the game are not accurate with the original ones so need to change all of them, and for example I translate the 404 ones like that because I did it based on the de.json file and is a literal translation, didn’t know the original one don’t have the 404 thing.

-Removed all text already translated at the gamemaster file src/util/locale/es.json
-Checked all translations to meet the rules.
@jfberry
Copy link
Collaborator

jfberry commented Jan 8, 2024

Since I don't speak spanish I have no way of verifying. Just let me know when ready to merge

@jfberry
Copy link
Collaborator

jfberry commented Mar 9, 2024

@CarlosVMX1 what is the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants