QuestsFix v4 - fallback lang to en when lang isnt in masterfile for Questtask #863
Conversation
|
Good idea, but wouldn't this be better just to fall back to 'en' inside getQuest? It knows immediately if the language entry cannot be retrieved and could just retrieve the english one |
ReuschelCGN
changed the title
|
the way it is now? for german translation it works but i have no chance to test it like above for users with language not in masterfile |
src/controllers/quest.js
Outdated
| @@ -387,6 +387,10 @@ class Quest extends Controller { | |||
| if (item.quest_task && !this.config.general.ignoreMADQuestString) { | |||
| str = item.quest_task | |||
| } else { | |||
| if (!Object.keys(this.GameData.translations).includes(language)) { | |||
There was a problem hiding this comment.
I think you could just do !this.GameData.translations[language] ?
since that would return undefined?
There was a problem hiding this comment.
this:
if (!Object.keys(this.GameData.translations).includes(language)) {
this.log.warn(`Missing language ${language}, fallback to english`)
language = 'en'
}
to:
language = !this.GameData.translations[language] ? 'en' : language
and no log entry, that it fallback ???
There was a problem hiding this comment.
a log entry is probably not required so this would work well.
some people don't like ?: as it doesn't scan as well visually; I have no problem with it
|
beautiful, if you confirm working will merge |
|
for german translation (no fallback) it works, but actually i have no possibility to test with fallback |
if user use language in poracle for dts, which isnt in masterfile, the questtask gen. fails - so:
check masterfile for available language and if it dosnt match to user language -> fallback to english
tested by dkmur in his multilang poracle