Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queststring fix #855

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Queststring fix #855

merged 2 commits into from
Jul 29, 2023

Conversation

ReuschelCGN
Copy link
Contributor

@ReuschelCGN ReuschelCGN commented Jul 28, 2023

fix to PR#838 Generate questString using quest_title from RDM looks like some backwards fix are needed
missing/away are:

  • questStringEng
  • quest_task from MADQuestString

str = str.replace('{{amount_0}}', item.target)

think i throws an error, if there is no {{amount_0}} and/or item.target!?!

no need for addtional config.general.unknownQuestString can use questTypes['quest_0'] in user language instead

@jfberry jfberry merged commit 243f306 into KartulUdus:develop Jul 29, 2023
@ReuschelCGN ReuschelCGN deleted the QueststringFix branch July 31, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants