-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pokemon showcase #850
add pokemon showcase #850
Conversation
I think we have some dts text which should return Showcase? |
src/controllers/pokestop.js
Outdated
@@ -147,6 +145,13 @@ class Invasion extends Controller { | |||
data.gruntName = data.displayTypeId && this.GameData.utilData.pokestopEvent[data.displayTypeId] ? this.GameData.utilData.pokestopEvent[data.displayTypeId] : '' | |||
data.gruntType = data.displayTypeId && this.GameData.utilData.pokestopEvent[data.displayTypeId] ? this.GameData.utilData.pokestopEvent[data.displayTypeId].toLowerCase() : '' | |||
data.gruntRewards = '' | |||
if (data.displayTypeId === 7) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be in util.json - see plenty of other examples.
Maybe the color and an emoji reference should be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this?
im actually working on it
"3": {
"name": "Instinct",
"color": "FFDE00",
"emoji": "team-instinct"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly
Let me know when ready for review |
we should also wait until PR#838 is merged !?! |
tracking e.g.
!invasion showcase d1000 clean
use in DTS something like:
{{#if (eq displayTypeId 9)}}Showcase{{else}}Invasion{{/if}}