Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pokemon showcase #850

Merged
merged 79 commits into from
Jul 28, 2023
Merged

add pokemon showcase #850

merged 79 commits into from
Jul 28, 2023

Conversation

ReuschelCGN
Copy link
Contributor

tracking e.g.
!invasion showcase d1000 clean

use in DTS something like:
{{#if (eq displayTypeId 9)}}Showcase{{else}}Invasion{{/if}}

@jfberry
Copy link
Collaborator

jfberry commented Jul 6, 2023

I think we have some dts text which should return Showcase?
Does it return Invasion where this makes sense also?
I think we should add !incident that calls the invasion code (ie they are the same command). I can do that or you can add to this PR (just needs to be in src/util/discord/commands and telegram commands)

@@ -147,6 +145,13 @@ class Invasion extends Controller {
data.gruntName = data.displayTypeId && this.GameData.utilData.pokestopEvent[data.displayTypeId] ? this.GameData.utilData.pokestopEvent[data.displayTypeId] : ''
data.gruntType = data.displayTypeId && this.GameData.utilData.pokestopEvent[data.displayTypeId] ? this.GameData.utilData.pokestopEvent[data.displayTypeId].toLowerCase() : ''
data.gruntRewards = ''
if (data.displayTypeId === 7) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in util.json - see plenty of other examples.
Maybe the color and an emoji reference should be there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this?
im actually working on it
"3": {
"name": "Instinct",
"color": "FFDE00",
"emoji": "team-instinct"
},

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly

@jfberry
Copy link
Collaborator

jfberry commented Jul 19, 2023

Let me know when ready for review

@ReuschelCGN
Copy link
Contributor Author

!incident parallel to !invasion -> works like expected
util.json change -> works like expected also in DTS
but it looks like, when a showcase (runs 3 days) message is tracked with clean command, the message is deleted in discord after 24h.... no idea why!

we should also wait until PR#838 is merged !?!

@jfberry jfberry merged commit a6bc50d into KartulUdus:develop Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants