Offset calibration broken in v1.7.0-b2

[lennremy]

Since version 1.7.0-b2, the calibration of Tado thermostats no longer works. The offset value is always set to 0°C. Although the temperature difference between thermostat and thermometer is detected and calculated in the logs, it is not properly transmitted to Tado.

Does work properly after downgrading to 1.7.0-b1.

2025-01-08 09:47:08.349 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Schlafzimmer: TRV climate.schlafzimmer sends new internal temperature from 20.5 to 20.6 2025-01-08 09:47:08.350 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Schlafzimmer: trigger_trv_change test / _old_heating_setpoint: 21.0 - _new_heating_setpoint: 21.0 - _last_temperature: 21.0 2025-01-08 09:47:08.351 DEBUG (MainThread) [custom_components.better_thermostat.model_fixes.model_quirks] better_thermostat BT Schlafzimmer: climate.schlafzimmer - calibration offset model fix: -2.400000000000002 to -2.4 2025-01-08 09:47:08.351 DEBUG (MainThread) [custom_components.better_thermostat.calibration] better_thermostat BT Schlafzimmer: climate.schlafzimmer - new local calibration: 0.0 | external_temp: 18.2, trv_temp: 20.6, calibration: 0.0 2025-01-08 09:47:08.509 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Wohnzimmer: TRV climate.wohnzimmer_2 sends new internal temperature from 22.5 to 22.4 2025-01-08 09:47:08.510 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Wohnzimmer: trigger_trv_change test / _old_heating_setpoint: 20.0 - _new_heating_setpoint: 20.0 - _last_temperature: 20.0

[folfy]

Please follow the bug report template, we need at least the debug data to understand your issue:
diagnostic data
IMPORTANT:
Download and paste the diagnostic data from your Better Thermostat Entity(s) below.
https://www.home-assistant.io/docs/configuration/troubleshooting/#download-diagnostics

The new, desired values is calculated as: new local calibration: 0.0, so not an issue of "setting" things. Fortunately the value for "tado" is hardcoded, so I can understand the issue without the diagnostic data. Needed to fix rounding in PR #1555, sry.

[lennremy]

Sorry for not following the template, I'm new to github and didnt know better.

I did include a snippet from the diagnostic data, but here is the full log I downloaded.
home-assistant_better_thermostat_2025-01-08T08-47-25.647Z.log

Do you need any additional information? I apologize again - I’m not a developer, but I wanted to try to help.

[folfy]

It's ok, for this issue fortunately everything should be clear, so we just need to test the fix and release a new b3 Version with it

[DavidGeorge528]

This issue does not seem to be fixed for me on Beta 3. I returned home today to half my TRVs in idle because the offset was too high even though the room temperature was well below the target temperature. I documented all my personal issues in #1559 which was closed as duplicate before Beta 3 was released, but the findings there seem to still persist. History view below to show the issue still persists:

At 19:52 I manually turned the TRV which triggered the offset to update and the TRV to turn on properly.

Screenshot to show Beta 3 installed:

[folfy]

@DavidGeorge528 Sorry, but the offset calibration was broken in b2, so it could not function and the logs are not rly helpful in analyzing some potential secondary issue, as any regulation issue is eclipsed by the bug we had.

What I see in the logs:
ERROR (MainThread) [custom_components.better_thermostat.utils.helpers] better_thermostat Bathroom: climate.bathroom_trv HVAC mode auto is not supported by this device, is it possible that you forgot to set the heat auto swapped option?

So make sure what your TRV supports is in line with what you set in BT for this. Failure to do so, can block things in BT.

If you still have issues, please create a new ticket with all the logs in the current version, or we will not be able to analyze it.

[DavidGeorge528]

I'm not entirely sure how this isn't related. I updated to Beta 3 which stated it fixed the issue and the exact same issue still exists, it isn't any different. The TRVs don't turn on because the offset is set too high even though the rooms actual temperature is well below the target.

As for settings, I showed them in the other issue. But here is the Bathroom one you quoted. It has auto means heat unchecked because my TRV has heat and no auto.

I've just turned the heating on again and still getting the same issue, I will start another log dump and make a new issue

[folfy]

@DavidGeorge528 this issue was about offset calibration being broken, as in not working at all (see the description - "always set to 0°C"), so not related to your potential problem at all, as you say your calibration is "too high".

If you rly think you got a problem, feel free to open a new ticket with all the required info about HW and your overall setup as well as graphs, logs and diagnostic data (all stated in the bug report template during issue creation). Can't guarantee we get to look into it immediately, it takes a lot of time, but trying our best atm. The better the quality of the bug report, the higher are your chances of us finding the actual issue.

[DavidGeorge528]

so not related to your potential problem at all, as you say your calibration is "too high".

If this is the case why was #1559 closed so quickly, and can it be re-opened? It took me a long time to make that issue, and a new issue would be largely the same information, as the issues I face are identical in beta 3

I can add another log dump to that issue if its re-opened for beta 3, but the information and charts are the same

[folfy]

@DavidGeorge528 We need a new debug log from b3 and matching graphs, or we waste idk how much time on finding out what even happened when from the textual logs only. As mentioned before, the current logs will not tell us anything, due to the old, known and now fixed bug. If you still have issues, feel free to provide new data and we can analyze it (as part of your original issue).

I know this is a bit of effort, but we spent way more hours on actually finding and solving your issue (I'm also just trying to help out here since a few weeks now), so please take your time for this, if you want us to be able to figure out the problem with your setup.

[DavidGeorge528]

I haven't had a chance to sit down and re-write another issue report like #1559, so instead because I needed my heating working properly I downgraded to the stable release of 1.6.1 and all of my issues went away. So there must be some issues still persistent in the betas when it comes to calibration offsets

[DavidGeorge528]

Managed to find time today to do a new issue with updated logs and graphs #1586