Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JFRTest fails with graal master: AllowVMInspection deprecated warning #107

Closed
jerboaa opened this issue Aug 24, 2022 · 2 comments · Fixed by #111
Closed

JFRTest fails with graal master: AllowVMInspection deprecated warning #107

jerboaa opened this issue Aug 24, 2022 · 2 comments · Fixed by #111
Assignees
@jerboaa

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Aug 24, 2022 •
edited
Loading

Discovered here:
https://github.com/graalvm/mandrel/runs/7987554026?check_suite_focus=true

Fails with:

Error:  Failures: 
Error:    JFRTest.jfrOptionsSmokeTest:157->jfrOptionsSmoke:288 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrOptionsSmokeTest/build-and-run.log and check these offending lines: 
Warning: Option 'AllowVMInspection' is deprecated and might be removed from future versions: Please use --enable-monitoring ==> expected: <true> but was: <false>
Error:    JFRTest.jfrSmokeTest:83->jfrSmoke:135 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel/mandrel/mandrel-integration-tests/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrSmokeTest/build-and-run.log and check these offending lines: 
Warning: Option 'AllowVMInspection' is deprecated and might be removed from future versions: Please use --enable-monitoring ==> expected: <true> but was: <false>

we should be using --enable-monitoring API option in 22.3+
This was referenced Aug 24, 2022
Closed
Closed
@jerboaa
Copy link
Collaborator Author

jerboaa commented Aug 30, 2022

@Karm Could you please look at this when you get a chance. Thanks!

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 22, 2022

I'll try to get this one fixed.

@jerboaa jerboaa assigned jerboaa and unassigned Karm Sep 22, 2022
jerboaa added a commit to jerboaa/mandrel-integration-tests that referenced this issue Sep 22, 2022
@jerboaa
Hot-replace VM inspection argument
78e6d89 
Depending on the graal vm version in use, use the appropriate
native-image option to allow for VM inspection.

Closes: Karm#107
@jerboaa jerboaa mentioned this issue Sep 22, 2022
Merged
jerboaa added a commit to jerboaa/mandrel-integration-tests that referenced this issue Sep 22, 2022
@jerboaa
Hot-replace VM inspection argument
c894655 
Depending on the graal vm version in use, use the appropriate
native-image option to allow for VM inspection.

Closes: Karm#107
jerboaa added a commit to jerboaa/mandrel-integration-tests that referenced this issue Sep 23, 2022
@jerboaa
Hot-replace VM inspection argument
8250266 
Depending on the graal vm version in use, use the appropriate
native-image option to allow for VM inspection.

Closes: Karm#107
zakkak pushed a commit that referenced this issue Sep 23, 2022
@jerboaa @zakkak
Hot-replace VM inspection argument
8a3aacd 
Depending on the graal vm version in use, use the appropriate
native-image option to allow for VM inspection.

Closes: #107
@jerboaa jerboaa mentioned this issue Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerboaa jerboaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hot-replace VM inspection argument jerboaa/mandrel-integration-tests
2 participants
@jerboaa @Karm