Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two bugs in weighted branch and reduce #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jabo17
Copy link
Contributor

@jabo17 jabo17 commented Aug 1, 2024

  1. fix bug in the use of get_current_is_weight() after calling restore_global_best_solution(): latter moves global_status to status but get_current_is_weight uses global_status; fixed it by introducing public method get_is_weight() and making get_current_is_weight() private
  2. fix bug in fold reductions; they added the wrong solution weight to is_weight; introduced additional invariants (assertions) to ensure the correctness of the modified solution weight

Note: Bug 2 became visible when fixing bug 1 in the final MIS weight.

…ore_global_best_solution(): latter moves global_status to status but get_current_is_weight uses global_status; fixed it by introducing public method get_is_weight() and making get_current_is_weight() private

- fixing bug in fold reductions; they added the wrong solution weight to is_weight
@jabo17 jabo17 changed the title - fixing bug in the use of get_current_is_weight() after calling rest… fix two bugs in weighted branch and reduce Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant