Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish 6 #3371

Merged
merged 5 commits into from
Nov 16, 2024
Merged

Polish 6 #3371

merged 5 commits into from
Nov 16, 2024

Conversation

majora2007
Copy link
Member

@majora2007 majora2007 commented Nov 15, 2024

We are nearing the release. Not too many issues are being reported.

Fixed

  • Fixed: Fixed an issue with floating point comparison making on deck out of whack. (develop)
  • Fixed: Sometimes covers wouldn't generate on scan (develop)
  • Fixed: Fixed people filtering not taking role into account (develop) (Fixes "As a role" bug when a person has two roles #3376)

…or > comparisions. Needs to be ported to other filters.
…hack. Streamlined all the floating code into Extension methods to avoid these issues in the future.
…en spun off to a separate task, some covers wouldn't get generated.
@majora2007 majora2007 merged commit c849eff into develop Nov 16, 2024
7 checks passed
@majora2007 majora2007 deleted the bugfix/polish6 branch November 16, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

"As a role" bug when a person has two roles
1 participant