-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comic Rework (Part 1) #2772
Merged
Merged
Comic Rework (Part 1) #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omicVine style). Started a big refactor for how the parsers work to split them into dedicated parsers and keep the code much easier to understand and maintain. Next up, make DefaultParser abstract and add/update unit tests.
…ogic is now streamlined and easily testable.
…Parsers code (DefaultParser). Cleaned up the unit tests but they need a full refresh to align with the new code.
…d clean it) if no other way to find information. Setup basic tests for the ComicVineParserTests.cs
…t (true root) into the individual Parsers. Refactored the Image library type to align more towards how a user is using it (given no feedback from users since I coded it). Added unit tests to Image Parser.
…detail api. Changed so that the new format is Chapter {number} - {title} (assumming title exists), else Chapter {number}. For Books, nothing has changed.
…ome UI issues with rendering titles for Image library and ComicVine.
…th Filtering. Fixed some bad styling on Chapter metadata (drawer)
…df parser. Added some basic tweaks to the pdf parser to be a bit better (but just small patch work until pdf refactor).
…rser didn't parse correctly. Misc cleanup around the UI when spot checking a larger sample size.
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pass of the Comic Rework and although I've already done 100 hours of dev work in Foundational Changes, this PR contains a huge number of foundation changes as well (and a ton of unit tests to boot).
This is the near full implementation of #2714, excluding handling Annuals that are within a Series as I am still in discussion on whether this should be encouraged or not (given CBLs expect them as their own series).
For those that are helping test these changes please note the following:
Where testing is needed:
Added
Changed
Fixed
Dev