feat(Canvas): Use hover styles upon open toolbar #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when opening the step toolbar upon hovering a node or a group, the hover style is lost when hovering over the toolbar. This commit retains the hover styling when the toolbar is open.
lordrip
force-pushed
the
feat/use-hover-styles
branch
from
0997110 to
0f9b117
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
=======================================
Coverage ? 79.73%
Complexity ? 273
=======================================
Files ? 285
Lines ? 8137
Branches ? 1602
=======================================
Hits ? 6488
Misses ? 1538
Partials ? 111 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
I do not spot the difference between the before and after images oO |
Notice that the before doesn't have the blue border, while the after has it. |
lhein
approved these changes
Nov 19, 2024
apupier
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when opening the step toolbar upon hovering over a node or a group, the hover style is lost when hovering over the toolbar.
Changes
This commit retains the hover styling when the toolbar is open.