-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(DND): Enable Simple DND #1620
Conversation
5e1e2c0
to
ea6483e
Compare
ea6483e
to
a34ba32
Compare
27a26a6
to
98e4a92
Compare
packages/ui/src/models/visualization/flows/abstract-camel-visual-entity.ts
Show resolved
Hide resolved
packages/ui/src/components/Visualization/Canvas/controller.service.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/Visualization/Custom/Group/CustomGroupCollapsible.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/Visualization/Custom/Group/CustomGroupExpanded.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/components/Visualization/Custom/Group/Group.models.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/Visualization/Custom/Node/PlaceholderNode.scss
Outdated
Show resolved
Hide resolved
packages/ui/src/models/visualization/flows/abstract-camel-visual-entity.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/models/visualization/flows/pipe-visual-entity.ts
Outdated
Show resolved
Hide resolved
98e4a92
to
f0b0632
Compare
f0b0632
to
b3d8b06
Compare
Quality Gate passedIssues Measures |
|
||
export const CustomGroupExpanded: FunctionComponent<CustomGroupProps> = observer( | ||
({ element, onContextMenu, onCollapseToggle }) => { | ||
export const CustomGroupExpandedInner: FunctionComponent<CustomGroupProps> = observer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For another PR: we don't need to export this component anymore :)
export const CustomGroupExpandedInner: FunctionComponent<CustomGroupProps> = observer( | |
const CustomGroupExpandedInner: FunctionComponent<CustomGroupProps> = observer( |
|
||
export const CustomNodeWithSelection = withContextMenu(NodeContextMenuFn)(CustomNode); | ||
export const CustomNodeWithSelection = withDndDrop(customNodeDropTargetSpec)( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For another PR: we can rename this component to CustomNode
export const CustomNodeWithSelection = withDndDrop(customNodeDropTargetSpec)( | |
export const CustomNode = withDndDrop(customNodeDropTargetSpec)( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shivamG640 👍 I'm merging this one so we can move to the next phase 💪
Fixes #80 partially
Following are the changes coming with this PR:
Above changes can be tested live here.
Note: