chore: Avoid double Maven build #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep a separate `build:mvn` for ease of read - currently there is no integration test and no need to install locally the generated artifact, so using `package` phase only (and not install or verify) - the impact of the change is that there will be `mvn clean` called also when calling directly `yarn run build:default:catalog`, which I think is acceptable - it is saving ~30 seconds of build time on CI Signed-off-by: Aurélien Pupier <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
=======================================
Coverage ? 80.02%
Complexity ? 259
=======================================
Files ? 276
Lines ? 7755
Branches ? 1509
=======================================
Hits ? 6206
Misses ? 1441
Partials ? 108 ☔ View full report in Codecov by Sentry. |
lordrip
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build:mvnfor ease of readpackagephase only (and not install or verify)mvn cleancalled also when calling directlyyarn run build:default:catalog, which I think is acceptable