Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix/test: NotNull check for a type param in DeplomentsResource + test expansion #688

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

mkralik3
Copy link
Contributor

@mkralik3 mkralik3 commented Jun 6, 2023

  • Add more tests for Deployments resources + native tests

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #688 (7a1bbd3) into main (682f465) will increase coverage by 0.87%.
The diff coverage is 100.00%.

❗ Current head 7a1bbd3 differs from pull request most recent head 205c630. Consider uploading reports for the commit 205c630 to get more accurate results

@@             Coverage Diff              @@
##               main     #688      +/-   ##
============================================
+ Coverage     79.47%   80.35%   +0.87%     
- Complexity      153      157       +4     
============================================
  Files            53       53              
  Lines          2709     2713       +4     
  Branches        432      432              
============================================
+ Hits           2153     2180      +27     
+ Misses          373      355      -18     
+ Partials        183      178       -5     
Impacted Files Coverage Δ
...o/backend/api/resource/v1/DeploymentsResource.java 84.90% <100.00%> (+19.59%) ⬆️

... and 3 files with indirect coverage changes

@mkralik3 mkralik3 force-pushed the deployments_tests branch 2 times, most recently from 2cf1bb9 to 28f72cb Compare June 8, 2023 08:08
* Add more tests for Deployments resources + native tests
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mkralik3 mkralik3 marked this pull request as ready for review June 8, 2023 11:18
@mkralik3 mkralik3 requested a review from a team June 8, 2023 11:18
@Delawen Delawen merged commit 8d02b6f into KaotoIO:main Jun 9, 2023
@mkralik3 mkralik3 deleted the deployments_tests branch August 3, 2023 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Native test corresponding to DeploymentsResourceTest
2 participants