Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

fix: expression object is filled with default values #578

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: expression object is filled with default values #578

merged 1 commit into from
Mar 28, 2023

Conversation

igarashitm
Copy link
Contributor

Fixes: #569

@igarashitm igarashitm requested a review from a team March 27, 2023 17:42
@codecov
Copy link

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

Merging #578 (ab3371c) into main (742577c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #578   +/-   ##
=========================================
  Coverage     78.85%   78.85%           
  Complexity      132      132           
=========================================
  Files            45       45           
  Lines          2289     2289           
  Branches        347      347           
=========================================
  Hits           1805     1805           
  Misses          322      322           
  Partials        162      162

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@igarashitm igarashitm enabled auto-merge (rebase) March 27, 2023 17:58
@Delawen
Copy link
Member

Delawen commented Mar 28, 2023

Plus conflicts, sorry :(

Delawen
Delawen suggested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Delawen Delawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change get with getOrDefault(key, null) to avoid potential keys missing.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.0% 16.0% Duplication

@Delawen Delawen disabled auto-merge March 28, 2023 13:01
@Delawen Delawen merged commit 7a9d6c2 into KaotoIO:main Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Delawen Delawen Delawen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] expression object is filled with default values
2 participants
@igarashitm @Delawen