Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore Increase PageSize for Windows GitHub Workflows doing native #417

Merged
merged 1 commit into from
Jan 23, 2023
Merged

chore Increase PageSize for Windows GitHub Workflows doing native #417

merged 1 commit into from
Jan 23, 2023
+13 −1

Conversation

apupier
Copy link
Member

@apupier apupier commented Jan 23, 2023

compilation

Following workaround mentioned here
actions/runner-images#3420 (comment) to the LINK : fatal error LNK1171: unable to load mspdbcore.dll (error code: 1455) error

fixes #416

@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Merging #417 (4e1073f) into main (27128d7) will increase coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 4e1073f differs from pull request most recent head 2cc880e. Consider uploading reports for the commit 2cc880e to get more accurate results

@@             Coverage Diff              @@
##               main     #417      +/-   ##
============================================
+ Coverage     78.96%   79.15%   +0.18%     
  Complexity      114      114              
============================================
  Files            45       45              
  Lines          2144     2144              
  Branches        306      306              
============================================
+ Hits           1693     1697       +4     
+ Misses          296      293       -3     
+ Partials        155      154       -1
Impacted Files Coverage Δ
...parser/camelroute/CamelRouteStepParserService.java 79.48% <0.00%> (+10.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@apupier
chore Increase PageSize for Windows GitHub Workflows doing native
2cc880e 
compilation

Following workaround mentioned here
actions/runner-images#3420 (comment)
to the `LINK : fatal error LNK1171: unable to load mspdbcore.dll (error
code: 1455)` error

fixes KaotoIO#416

Signed-off-by: Aurélien Pupier <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@apupier
Copy link
Member Author

apupier commented Jan 23, 2023

5 success in a row for Windows Native: https://github.com/KaotoIO/kaoto-backend/actions/runs/3985356993 (so seems to also stabilize #412 )

@apupier apupier marked this pull request as ready for review January 23, 2023 13:00
@apupier apupier requested a review from a team January 23, 2023 13:00
@apupier
Copy link
Member Author

apupier commented Jan 23, 2023

the security/snyk PR is not starting but it is touching only configuration of the GitHub Workflow so there won't be any impact

@apupier apupier mentioned this pull request Jan 23, 2023
Closed
@Delawen Delawen merged commit f4adaf6 into KaotoIO:main Jan 23, 2023
@apupier apupier deleted the fixMain-ntiveCompilation branch June 13, 2023 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Delawen Delawen Delawen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] LINK : fatal error LNK1171: unable to load mspdbcore.dll (error code: 1455)
2 participants
@apupier @Delawen