Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming typealias package so it doesn't require backticks #114

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Kantis
Copy link
Owner

@Kantis Kantis commented Feb 23, 2024

Fixes #113

@Kantis Kantis added this to the 0.6 milestone Feb 23, 2024
@Kantis
Copy link
Owner Author

Kantis commented Feb 23, 2024

Seems IntelliJ can't deal with the ReplaceWith expression.. if anyone can figure it out it would be helpful, but if not we can add upgrade instructions to do a global search-and-replace to fix the imports.

@sschuberth
Copy link
Collaborator

Seems IntelliJ can't deal with the ReplaceWith expression..

I wasn't sure what you're referring to, but now that I tried I can confirm that clicking on the "Replace with" hint that IntelliJ show does nothing. Looks like a regression from https://youtrack.jetbrains.com/issue/KTIJ-10061/Replace-with-intention-does-not-work-for-equal-names.

@Kantis
Copy link
Owner Author

Kantis commented Feb 26, 2024

Nice find, I'll re-add the ReplaceWith hints. Hopefully it works in some IntelliJ versions at least, then.

Thought I removed the hints when I realized they didn't work.

@Kantis Kantis merged commit 1968dbf into main Feb 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing the typealias package name
2 participants