Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-support stream mode #110

Merged
merged 13 commits into from
Sep 8, 2024
Merged

re-support stream mode #110

merged 13 commits into from
Sep 8, 2024

Conversation

Kanahiro
Copy link
Owner

@Kanahiro Kanahiro commented Sep 8, 2024

  • toBuffer() takes about 30ms
  • streaming takes about 50ms

streaming is slower than about 20ms but it may compensate in downloading.

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 96 lines in your changes missing coverage. Please review.

Project coverage is 58.09%. Comparing base (2771280) to head (45a2715).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/server/index.ts 15.15% 56 Missing ⚠️
src/index.ts 0.00% 23 Missing and 1 partial ⚠️
src/render/index.ts 40.74% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   58.76%   58.09%   -0.67%     
==========================================
  Files          19       19              
  Lines        1484     1575      +91     
  Branches       92       98       +6     
==========================================
+ Hits          872      915      +43     
- Misses        609      657      +48     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kanahiro Kanahiro merged commit 7cd6050 into main Sep 8, 2024
4 of 6 checks passed
@Kanahiro Kanahiro deleted the feat/stream branch September 8, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant