Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carbs on board is invisible if there are no glucose readings #168

Closed
Kalhama opened this issue Oct 8, 2024 · 3 comments
Closed

Carbs on board is invisible if there are no glucose readings #168

Kalhama opened this issue Oct 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Kalhama
Copy link
Owner

Kalhama commented Oct 8, 2024

No description provided.

@Kalhama Kalhama added the bug Something isn't working label Oct 8, 2024
@Kalhama
Copy link
Owner Author

Kalhama commented Oct 8, 2024

No glucose readings -> metrics is empty -> no attributed carbs -> no carbs on board.

Moreover
no carbs on board -> glucose prediction crossjoin returns empty -> no glucose prediction

@Kalhama
Copy link
Owner Author

Kalhama commented Oct 8, 2024

Possible solution: join empty timestamps to metrics

@Kalhama
Copy link
Owner Author

Kalhama commented Oct 8, 2024

Related: #162

Kalhama added a commit that referenced this issue Oct 8, 2024
@Kalhama
fix Carbs on board is invisible if there are no glucose readings #168
5db79fe
@Kalhama Kalhama closed this as completed Oct 8, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Gluwave roadmap Oct 8, 2024
Kalhama added a commit that referenced this issue Oct 8, 2024
@Kalhama
refactor(gluwave): ♻️ use TRPC for getting data to client
8070dd9 
fix: carbs on board is invisible if there are no glucose readings #168
@Kalhama Kalhama mentioned this issue Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Gluwave roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kalhama