Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attributed_carbs should be weighed by active_time #129

Closed
Kalhama opened this issue Oct 1, 2024 · 0 comments
Closed

attributed_carbs should be weighed by active_time #129

Kalhama opened this issue Oct 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Kalhama
Copy link
Owner

Kalhama commented Oct 1, 2024

When calculating carbs on board / attributing observed carbs to meals, the meal is assumed start at the timestep starting point or end at its ending point if it exists in the timestep even for a second.

With CGM this is not that much of an issue, but with fingerpricking this renders the carbs on board pretty much useless.
@Kalhama Kalhama added the enhancement New feature or request label Oct 1, 2024
@Kalhama Kalhama changed the title Weight atributed_carbs by active_time Weigh atributed_carbs by active_time Oct 8, 2024
@Kalhama Kalhama mentioned this issue Oct 8, 2024
Closed
@Kalhama Kalhama moved this from Backlog to Todo in Gluwave roadmap Oct 8, 2024
@Kalhama Kalhama added bug Something isn't working and removed enhancement New feature or request labels Oct 8, 2024
@Kalhama Kalhama changed the title Weigh atributed_carbs by active_time atributed_carbs should be weighed by active_time Oct 8, 2024
@Kalhama Kalhama changed the title atributed_carbs should be weighed by active_time attributed_carbs should be weighed by active_time Oct 8, 2024
@Kalhama Kalhama mentioned this issue Oct 9, 2024
Open
Kalhama added a commit that referenced this issue Oct 10, 2024
@Kalhama
fix(gluwave): attributed_carbs should be weighed by active_time #129
401e7ea
@Kalhama Kalhama moved this from Todo to Done in Gluwave roadmap Oct 10, 2024
@Kalhama Kalhama closed this as completed by moving to Done in Gluwave roadmap Oct 10, 2024
@Kalhama Kalhama mentioned this issue Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Gluwave roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kalhama