Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove title attribute from dropdown item label #2039

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

pixelflips
Copy link
Member

Description

Title attribute in React DropdownItem displays [object object] in KP with generated list items.

This PR removes the title from the labels since it's already a duplicate of the actual label text.

Screenshots

Before After
Screenshot 2025-01-16 at 10 58 26 AM Screenshot 2025-01-16 at 10 58 49 AM

Testing in sage-lib

Testing in kajabi-products

  1. (LOW) Removes title attribute on dropdown item labels.

Related

https://kajabi.atlassian.net/browse/DSS-1237

@pixelflips pixelflips self-assigned this Jan 16, 2025
@pixelflips pixelflips requested a review from a team January 16, 2025 19:02
@pixelflips pixelflips changed the title fix: remove title from dropdown item label fix: remove title attribute from dropdown item label Jan 16, 2025
@pixelflips pixelflips merged commit 404bc02 into develop Jan 16, 2025
7 checks passed
@pixelflips pixelflips mentioned this pull request Jan 16, 2025
pixelflips added a commit that referenced this pull request Jan 17, 2025
* style: adds greet condensed font to Sage

* style: update mobile typeahead item styles (#2036)

* style(typeahead): update mobile typeahead item styles

* chore: css reordering

* chore(deps): bump @pine-ds/icons from 8.12.0 to 8.13.0 (#2037)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.12.0 to 8.13.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.12.0...v8.13.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: remove title attribute from dropdown item label (#2039)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Quinton Jason <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Phillip Lovelace <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants