Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken image paths #2029

Merged
merged 1 commit into from
Dec 2, 2024
Merged

docs: update broken image paths #2029

merged 1 commit into from
Dec 2, 2024

Conversation

pixelflips
Copy link
Member

Description

Noticed that on the upload card and media tile docs pages, the images are broken.
Adjusts the image paths so that images load properly.

Screenshots

Before After
Screenshot 2024-11-27 at 3 43 32 PM Screenshot 2024-11-27 at 3 43 45 PM
Screenshot 2024-11-27 at 3 45 34 PM Screenshot 2024-11-27 at 3 44 45 PM

Testing in sage-lib

Navigate to upload card
Verify images loading

Navigate to media tile
Verify images are loading

Testing in kajabi-products

  1. (LOW) Documentation update. No effect on KP.

@pixelflips pixelflips self-assigned this Nov 27, 2024
@pixelflips pixelflips marked this pull request as ready for review November 28, 2024 00:03
@pixelflips pixelflips requested a review from a team November 28, 2024 00:04
Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@monicawheeler monicawheeler requested a review from a team November 28, 2024 00:27
@pixelflips pixelflips merged commit f3d9000 into develop Dec 2, 2024
7 checks passed
@pixelflips pixelflips mentioned this pull request Dec 2, 2024
ju-Skinner pushed a commit that referenced this pull request Dec 13, 2024
* Badge: border and color updates (#2022)

* chore(ci): updating rails gem version [ci skip]

* chore(release): publish [skip ci]

* style(badge): rework documentation and styles for border and color updates

* fix(linter): remove extra spaces and reorg style order

* style(badge): rearrange badge preview and update styles

* fix: linting issue in the scss for order of props

* docs(badge): minor adjustments to grammar

* style(dot): adjust sage-badge dot spacing to align with designs

* revert versions to match develop

* fix: remove extra space in changelog

---------

Co-authored-by: Kajabi Automation Bot <[email protected]>

* docs: update broken image paths (#2029)

* chore(deps): bump @pine-ds/icons from 8.11.0 to 8.12.0 (#2028)

Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.11.0 to 8.12.0.
- [Release notes](https://github.com/Kajabi/pine-icons/releases)
- [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md)
- [Commits](Kajabi/pine-icons@v8.11.0...v8.12.0)

---
updated-dependencies:
- dependency-name: "@pine-ds/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Kajabi Automation Bot <[email protected]>
Co-authored-by: Phillip Lovelace <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants