Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add :focus to correct styles on button focus #2010

Merged
merged 1 commit into from
Oct 17, 2024
Merged

style: add :focus to correct styles on button focus #2010

merged 1 commit into from
Oct 17, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Oct 17, 2024 •
edited
Loading

Description

In KP, button colors are incorrect on focus due to focus-visible change.
This adds back focus for the color adjustments.

Screenshots

Before After
Screenshot 2024-10-17 at 1 16 07 PM Screenshot 2024-10-17 at 1 14 28 PM

Testing in sage-lib

  • Navigate to button
  • Verify button focus works as expected

Testing in kajabi-products

  • Enable bridge
  • Navigate around admin
  • Verify focus on the buttons displays the correct colors.
  1. (MEDIUM) Correct button color styles on focus.
    • Any buttons

Related

https://kajabi.atlassian.net/browse/DSS-1132

@pixelflips pixelflips self-assigned this Oct 17, 2024
@pixelflips pixelflips marked this pull request as ready for review October 17, 2024 20:19
@pixelflips pixelflips requested a review from a team October 17, 2024 20:19
@pixelflips pixelflips changed the title style: add focus to correct styles on button focus style: add :focus to correct styles on button focus Oct 17, 2024
@anechol anechol requested a review from a team October 17, 2024 20:20
@pixelflips pixelflips merged commit 36a705b into develop Oct 17, 2024
7 checks passed
@pixelflips pixelflips deleted the style/button-focus-color branch October 17, 2024 21:04
@pixelflips pixelflips mentioned this pull request Oct 17, 2024
Merged
ju-Skinner pushed a commit that referenced this pull request Oct 18, 2024
@pixelflips @kajabi-bot
style: add focus to correct styles on focus (#2010)
ccb1cd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicawheeler monicawheeler monicawheeler approved these changes

@anechol anechol anechol approved these changes

Assignees

@pixelflips pixelflips

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelflips @anechol @monicawheeler