Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: correct dropdown select size and fonts #2009

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Oct 16, 2024

Description

Dropdown select variant height and fonts are incorrect due to button changes
This PR updates the dropdown select size and fonts to match other inputs.

Screenshots

Before After
Screenshot 2024-10-16 at 5 00 03 PM Screenshot 2024-10-16 at 4 42 35 PM

Testing in sage-lib

Navigate to Dropdown
Check font is now Inter (weight 500) and height is now 40px.

Testing in kajabi-products

  1. (LOW) Adjusts font/height of Select Dropdown.

Related

https://kajabi.atlassian.net/browse/DSS-1128

@pixelflips pixelflips self-assigned this Oct 16, 2024
@pixelflips pixelflips marked this pull request as ready for review October 17, 2024 00:01
@pixelflips pixelflips requested a review from a team October 17, 2024 00:01
@monicawheeler monicawheeler requested a review from a team October 17, 2024 02:42
Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pixelflips pixelflips merged commit 05555d5 into develop Oct 17, 2024
7 checks passed
@pixelflips pixelflips mentioned this pull request Oct 17, 2024
@pixelflips pixelflips deleted the style/select-dropdown-size-font branch October 17, 2024 21:12
ju-Skinner pushed a commit that referenced this pull request Oct 18, 2024
* style: correct dropdown select size and fonts

* style: add font-family

* style: lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants