Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(choice): correct icon alignment #1957

Merged
merged 2 commits into from
Aug 22, 2024
Merged

style(choice): correct icon alignment #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0eefb0
style(choice): remove incorrect margin styles
pixelflips Aug 21, 2024
56addf8
docs(choice): add additional example without subtext
pixelflips Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/app/views/examples/components/choice/_preview.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ long_description = "Description with longer text to cause wrapping and make the

<h3 class="t-sage-heading-6">Icon Variation</h3>
<p>Select any icon to appear to the left of the text.</p>
<%= sage_component SageChoice, {
target: "example",
text: "Option 1",
type: "icon",
icon: "video-on",
}
%>

<p>With additional subtext.</p>
<%= sage_component SageChoice, {
target: "example",
text: "Option 1",
Expand Down
4 changes: 0 additions & 4 deletions packages/sage-assets/lib/stylesheets/components/_choice.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,6 @@ $-choice-radio-color-checked-inner: map-get($sage-radio-colors, checked-inner);
transition: color map-get($sage-transitions, default);
}

pds-icon {
margin-top: var(--icon-top-offset);
}

&.sage-choice--vertical-align-icon-start::#{$-choice-el-icon} {
align-self: start;
margin-top: var(--icon-top-offset);
Expand Down
Loading