fix(label): convert icon to pds-icon #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
requested review from
QuintonJason,
ju-Skinner,
anechol and
monicawheeler
pixelflips
changed the title
monicawheeler
approved these changes
Jun 20, 2024
ju-Skinner
approved these changes
Jun 21, 2024
Merged
ju-Skinner
pushed a commit
that referenced
this pull request
Jun 21, 2024
* chore: update Storybook source path for local and prod environment * Disable lint warnings for dependencies (#1889) * chore: update Storybook source path for local and prod environment * fix: resolve linting errors * fix: revert preview-head file change --------- Co-authored-by: Julian Skinner <[email protected]> * fix(label): convert icon to pine (#1896) * fix(Icon): adds back rest to icon component (#1898) * fix: adds back rest to icon * fix: add rest to element --------- Co-authored-by: Julian Skinner <[email protected]> Co-authored-by: Monica Wheeler <[email protected]>
This was referenced Jun 21, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates label icon to pds-icon in deprecated label react component. There is usage still in KP.
Screenshots
No visual changes are expected.
Testing in
sage-libThere is no story available in sage-lib, so will verify on the KP side.
Testing in
kajabi-productsRelated
N/A