Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Select: Rails documentation update #1808

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Form Select: Rails documentation update #1808

merged 4 commits into from
Oct 20, 2023

Conversation

monicawheeler
Copy link
Collaborator

Description

Update Form Select documentation to better explain props in Rails.

Screenshots

Before After
Screenshot 2023-10-11 at 3 14 22 PM Screenshot 2023-10-11 at 3 13 25 PM

Testing in sage-lib

  1. Navigate to http://localhost:4000/pages/component/form_select?tab=preview
  2. Verify the documentation renders and is valid

Testing in kajabi-products

  1. (LOW) Documentation only update, nothing tested in kajabi-products

@monicawheeler monicawheeler added the documentation Improvements or additions to documentation label Oct 11, 2023
@monicawheeler monicawheeler requested a review from a team October 11, 2023 21:17
@monicawheeler monicawheeler self-assigned this Oct 11, 2023
pixelflips
pixelflips approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@pixelflips pixelflips requested a review from a team October 11, 2023 21:51
@ju-Skinner ju-Skinner requested a review from a team October 16, 2023 16:59
@monicawheeler monicawheeler merged commit c62e20c into develop Oct 20, 2023
@monicawheeler monicawheeler deleted the docs/rails-select-documentation branch October 20, 2023 16:09
@monicawheeler monicawheeler mentioned this pull request Oct 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@monicawheeler monicawheeler

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monicawheeler @pixelflips @ju-Skinner