Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): error occurring locally with PropTypes.object() #1571

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

ju-Skinner
Copy link
Collaborator

Description

Error when running locally was discovered by @pixelflips...See slack thread

Solution

It was identified that the propType PropTypes.object() caused the problem. So we changed that to PropTypes.shape({}).

Unexpected error while loading ./Card/Card.story.jsx: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
 Invariant Violation: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them.```

@ju-Skinner ju-Skinner requested a review from a team August 25, 2022 18:01
@ju-Skinner ju-Skinner self-assigned this Aug 25, 2022
Copy link
Contributor

@philschanely philschanely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed a fix on my end as well 🙌

Copy link
Contributor

@anechol anechol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@ju-Skinner ju-Skinner merged commit cbeedca into develop Aug 25, 2022
@ju-Skinner ju-Skinner deleted the hotfix/error-with-proptypes_object branch August 25, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants