Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sage-753] Modal - Size Prop Based on Container #1569

Merged
merged 2 commits into from
Aug 25, 2022
Merged

[Sage-753] Modal - Size Prop Based on Container #1569

merged 2 commits into from
Aug 25, 2022

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Aug 23, 2022

Description

Adds a new prop size to allow for modal sizes based on container sizes.

Screenshots

Screen Shot 2022-08-23 at 11 35 07 AM

Testing in sage-lib

  • Navigate to Modal
  • Click "Modal with Size Option" button
  • Check that modal container properly changes width to mapped container value

Testing in kajabi-products

(LOW) Adds a new prop size to allow for modal sizes based on container sizes.

Related

Sage-753

@anechol anechol added the improvement Improve on existing work label Aug 23, 2022
@anechol anechol requested review from a team August 23, 2022 16:42
@anechol anechol self-assigned this Aug 23, 2022
@anechol anechol marked this pull request as draft August 24, 2022 13:54
@anechol anechol force-pushed the SAGE-753/ae-modal-size-mod branch from 7df38f9 to b33e01d Compare August 24, 2022 19:18
@anechol anechol marked this pull request as ready for review August 24, 2022 21:20
@anechol anechol requested review from a team and removed request for a team August 24, 2022 21:20
philschanely
philschanely approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@philschanely philschanely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

@philschanely philschanely requested a review from a team August 24, 2022 21:50
pixelflips
pixelflips approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@pixelflips pixelflips requested a review from a team August 24, 2022 21:56
@ju-Skinner ju-Skinner requested a review from a team August 25, 2022 14:23
@anechol anechol merged commit 75b85c8 into develop Aug 25, 2022
@anechol anechol deleted the SAGE-753/ae-modal-size-mod branch August 25, 2022 14:24
@anechol anechol mentioned this pull request Aug 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschanely philschanely philschanely approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@anechol anechol

Labels
improvement Improve on existing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anechol @pixelflips @ju-Skinner @philschanely