Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form elements: add AttachInternals #360

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Jan 10, 2025

Description

There is a need coming from XF to expose the ElementInternals interface to our web components. The ElementInternals interface of the DOM gives web developers a way to allow custom elements to fully participate in HTML forms.

Type of change

Please delete options that are not relevant.
If your type of change is not present, add that option.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@QuintonJason QuintonJason self-assigned this Jan 10, 2025
@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 88b99bf
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/678088edc46d7700082c75e9
😎 Deploy Preview https://deploy-preview-360--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner force-pushed the main branch 4 times, most recently from bab7cd1 to 05e3572 Compare February 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant