Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database grooming #102

Merged
merged 3 commits into from
Jan 10, 2025
Merged

database grooming #102

merged 3 commits into from
Jan 10, 2025

Conversation

kluvin
Copy link
Member

@kluvin kluvin commented Jan 8, 2025

closes #72

Oppdatert Pocketbase modell

  1. ✅ flertall -> entall -- (minus one-to-many)
  2. ✅ Kall orderDrink for order_item
  3. ✅ snake_case på a_l_t
  4. ✅ Fjerne drinks.kind (den er alt definert som en egen tabell categories)
  5. ✅ price -> price_in_nok
  6. ✅ Slett milk, extras, flavor, serving_size
  7. ✅ Fjerne purchased_cup
  8. ✅ activeMessage.isVisible -> activeMessage.online
  9. ✅ activeMessage kalt status?
  10. ✅ subtext -> subtitle
  11. ✅ displayMessage -> message

Oppdater kodebase [checklist for review]

  1. 🈹 flertall -> entall -- (minus one-to-many)
  2. 🈹 Kall orderDrink for order_item
  3. 🈹 snake_case på a_l_t
  4. 🈹 Fjerne drinks.kind (den er alt definert som en egen tabell categories)
  5. 🈹 price -> price_in_nok
  6. 🈹 Slett milk, extras, flavor, serving_size
  7. 🈹 Fjerne purchased_cup
  8. 🈹 activeMessage.isVisible -> activeMessage.online
  9. 🈹 activeMessage kalt status?
  10. 🈹 subtext -> subtitle
  11. 🈹 displayMessage -> message

Ikke gjort:

  1. Implementer Customizations for bestillinger #76 (?)

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Visit the preview URL for this PR (updated for commit c88130a):

https://kaffe-diem--pr102-database-grooming-gyzt6kjh.web.app

(expires Thu, 16 Jan 2025 09:26:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 442774dd5e8e2b443bd55c0d98e4d4879d91742b

@IldenH
Copy link
Member

IldenH commented Jan 8, 2025

drink -> item? gjør det mer generisk hvis de vil selge vafler eller noe.
price_in_nok -> price_nok? synes det er litt langt

#76 er nok ikke nødvendig å gjøre før denne.

@kluvin
Copy link
Member Author

kluvin commented Jan 9, 2025

drink -> item? gjør det mer generisk hvis de vil selge vafler eller noe. price_in_nok -> price_nok? synes det er litt langt

#76 er nok ikke nødvendig å gjøre før denne.

Enig.

Glemte å bytte navn, om forlat! Men det var absolutt i scope.

price_nok kan jeg gå med på.

singular noun
snake_case
drink -> item
other renaming
@kluvin kluvin force-pushed the database-grooming branch from 69e100a to 268ae48 Compare January 9, 2025 07:54
@IldenH
Copy link
Member

IldenH commented Jan 9, 2025

Kan du fikse lint errorsene?

@kluvin
Copy link
Member Author

kluvin commented Jan 10, 2025

takk for bistand @IldenH

@kluvin kluvin requested review from IldenH and LilleAila January 10, 2025 11:02
@IldenH IldenH merged commit f9edcd0 into main Jan 10, 2025
5 checks passed
IldenH added a commit that referenced this pull request Jan 12, 2025
IldenH added a commit that referenced this pull request Jan 12, 2025
LilleAila added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database grooming (pre-migrations checklist)
3 participants