Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make release builds reproducible #182

Merged
merged 4 commits into from
May 14, 2024

Conversation

mbreithecker
Copy link
Member

@mbreithecker mbreithecker commented May 6, 2024

This PR makes sure that all builds (even cross-compile) are reproducible.
For the release packages it is unfortunately not possible to make the tar.gz packages reproducible across operating systems as the final compressed file is different depending on the OS. Therefore, the raw binaries are also included in the release folder now.

Summary by CodeRabbit

  • New Features
    • Enhanced the build process by including a specific build time format and additional build flags for improved compilation control.
  • Chores
    • Updated the release creation process to set timestamps for generated files, ensuring better tracking and consistency of builds.

Copy link

coderabbitai bot commented May 6, 2024

Walkthrough

The recent changes focus on enhancing the build system by incorporating a specific BUILD_TIME constant, updating BUILD_FLAGS with a new flag, and refining the release creation process to support multiple OS and architectures with timestamps and checksums.

Changes

File Change Summary
Makefile Added BUILD_TIME; updated BUILD_FLAGS; refactored release creation for multi-OS support with timestamps and checksums

🐰✨
In the code's dance, new steps are spun,
Time's embrace, flags now won.
Releases refined under the sun,
Timestamps set for each one.
Hoppity hop, the build is won!
🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 6e0aba8 and 3a4d92c.
Files selected for processing (1)
  • Makefile (3 hunks)
Files skipped from review due to trivial changes (1)
  • Makefile

Makefile Outdated Show resolved Hide resolved
@troykessler troykessler self-requested a review May 14, 2024 08:45
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3a4d92c and 9cdcda0.
Files selected for processing (1)
  • Makefile (3 hunks)
Additional comments not posted (3)
Makefile (3)

7-7: The addition of BUILD_TIME with the specified format looks good.


36-36: The inclusion of -buildvcs=false in BUILD_FLAGS is appropriate for ensuring reproducible builds.


66-71: The use of touch to set timestamps and sha256sum to generate checksums is appropriate for ensuring reproducibility and integrity.

Makefile Show resolved Hide resolved
@mbreithecker mbreithecker merged commit d306dd2 into main May 14, 2024
5 checks passed
@mbreithecker mbreithecker deleted the mbreithecker/reproducible-builds branch May 14, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants