feat: JD 등록, 자소서 등록 API 구현(#56) #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isprogrammingfun
changed the title
dojinyou
reviewed
May 18, 2024
Comment on lines
+3
to
+6
| data class CreateApplyContent ( | ||
| val question: String, | ||
| val answer: String | ||
| ) |
There was a problem hiding this comment.
이 부분은 저 또한 분리할 이유가 없다 생각이 들어 리펙터링 할 때 로직을 합치려고 했습니다! 좋은 리뷰 감사합니다:)
Comment on lines
+21
to
+27
| request.contents.forEach { content -> | ||
| applyContentAppender.appendApplyContent( | ||
| applyId = apply.id, | ||
| question = content.question, | ||
| answer = content.answer | ||
| ) | ||
| } |
Comment on lines
+35
to
+51
| fun toDomain( | ||
| id: UUID, | ||
| title: String, | ||
| writeStatus: WriteStatus, | ||
| createdAt: LocalDateTime, | ||
| updatedAt: LocalDateTime, | ||
| jobDescriptionId: UUID | ||
| ): Apply { | ||
| return Apply( | ||
| id = id, | ||
| title = title, | ||
| writeStatus = writeStatus, | ||
| createdAt = createdAt, | ||
| updatedAt = updatedAt, | ||
| jobDescriptionId = jobDescriptionId | ||
| ) | ||
| } |
There was a problem hiding this comment.
이 메서드는 오히려 사용하는 곳에서 정의가 되어야 할 것 같아요.
네이밍이나 역할 모두 여기에 정의되기엔 부적절해 보여요
There was a problem hiding this comment.
좋은 리뷰 감사합니다! 관련해서 리팩터링 해보도록 하겠습니다:)
| val updatedAt: LocalDateTime, | ||
| val startedAt: LocalDateTime, | ||
| val endedAt: LocalDateTime, | ||
| val userId: UUID, |
There was a problem hiding this comment.
도메인의 이해가 부족해서인지 jd에 userId가 들어가야 하는지 이해하기 어려운 것 같아요!
There was a problem hiding this comment.
사용자 별로 JD를 등록할 수 있고 작성한 JD를 따로 조회하는 로직이 있어 추가했었습니다!
| applyContent.answer shouldBe answer | ||
| } | ||
|
|
||
| test("applyContent 입력값으로 공백이 들어오면 에러 반환") { |
There was a problem hiding this comment.
입력 파라미터에 따라 테스트 분리하고 공백 외에도 whitespace도 고려해보면 좋을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
📋 추후 진행 사항
📌 리뷰 요청 사항