feat: 경험 목록 조회 API 구현(#42) #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
isprogrammingfun
approved these changes
May 20, 2024
| } | ||
| } | ||
|
|
||
| private fun createExperienceDetailResponse(it: Experience): DetailExperience.Response { |
There was a problem hiding this comment.
이거 it으로 표현하니까 직관적이지가 않은 거 같은데 네이밍 수정해줄래?
| .let { ExperienceYear.Response(it) } | ||
| } | ||
|
|
||
| fun getExperienceByYearAndParentTag(year: Int, parentTagId: UUID): List<DetailExperience.Response> { |
There was a problem hiding this comment.
dto가 리스트일때는 dto로 한번 더 감싸는거 어때?
data class Response(
val applyContentList: List<ContentInfo>
)
data class ContentInfo(
val question: String,
val answer: String
)
요런식으루
| @@ -18,6 +18,16 @@ class ExperienceController( | |||
| private val experienceEditService: ExperienceEditService, | |||
| private val experienceGetService: ExperienceGetService | |||
| ) { | |||
| @GetMapping(ExperienceApi.BASE_URL) | |||
| fun getExperienceByFilter(@RequestParam("year") year: Int, | |||
| @RequestParam("parent-tag", required = false) parentTagId: UUID, | |||
There was a problem hiding this comment.
얘는 왜 ? 가 없나요오 그리구 ?연산자 사용하면 required = false 필요없긴 해
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
경험 목록 조회 API 구현
📋 추후 진행 사항
경험 검색 API 구현
📌 리뷰 요청 사항
조회하는 방식이 현재 각 Reader들을 가져와서 경험 내부에 들어갈 DTO들을 만드는 방식인데, 뭔가 코드가 길어지고 반복되는 느낌! 이것도 리팩토링 필요...