Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fixing type error + keyword analysis per-year functionality #76

Merged
merged 4 commits into from
Feb 24, 2022
Merged

[FIX] fixing type error + keyword analysis per-year functionality #76

merged 4 commits into from
Feb 24, 2022

Conversation

testation21
Copy link

The KUBIC system uses Angular + TypeScript + LessCSS.
Also, it uses the D3 library as a visualization tool.
However, D3 library is written in JS and targeted to JS system.
Therefore, it is not precisely compatible.

For example, correct JS code could be type error in TS.
To avoid this issue, TS provides the @ts-nocheck annotation.
Therefore, I adopted the annotation in D3 visualization for the pie chart.

@testation21 testation21 changed the title [FIX] fixing type error [FIX] fixing type error + keyword analysis per-year functionality Feb 23, 2022
@testation21
Copy link
Author

Keyword analysis per-year related to #71

@lamb0711 lamb0711 merged commit a42efd5 into KUBIC-HGU:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants